The same user is treated as both:

1. Someone who already received their reward.

2. Someone entitled to the remaining rewards.

Description

• When a player claims their assigned reward through claimCut(), their reward should be considered consumed.

  The player's reward is set to zero:

  playersToRewards[player] = 0;

  Therefore, the player should not receive the same entitlement again unless the protocol explicitly defines a separate bonus.

• Specific issue

  claimCut() adds every successful claimant to the claimants array:

  claimants.push(player);

  Later, closePot() sends another amount to every address in claimants.

  Therefore, every player who already claimed their reward receives an additional payment when the Pot closes.

Risk

Likelihood:

• Every successful claimant is added to claimants.

• Every address in claimants is paid again during closePot().

Impact:

• Claimants receive duplicate payouts.

• The intended reward allocation can be exceeded.

• Other participants may receive fewer rewards because additional tokens are sent to already-paid users.

Proof of Concept

Recommended Mitigation