MyCut

AI First Flight #8
Beginner FriendlyFoundry
EXP
View results
Submission Details
Impact: high
Likelihood: high
Invalid

Unchecked return values of ERC20 transfer and transferFrom calls

The fundContest function in ContestManager and the _transferReward and closePot functions in Pot use standard IERC20.transfer and IERC20.transferFrom methods without verifying their boolean return values. Some ERC20 tokens do not revert on failure but instead return false, which would cause the contract to silently fail to transfer funds while still accounting for them. Other tokens do not return a boolean at all, which would cause the calls to revert. OpenZeppelin's SafeERC20 library should be used to handle these non-standard implementations safely.

Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge 4 days ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!