Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Impact: low
Likelihood: medium
Invalid

IWETH transfer may fail silently in `collectFee()`

Root

The return value of i_weth.transfer() were not used, which will not detect WETH transfer failure. Downgraded the issue severity to low, since it is unlikely to result in catastrophic loss of funds. (collectFee is guarded by onlyCollector() modifier).

Impact

The impact is almost minimal to non-existent, since a failed WETH transfer would not update both the sender and recipient balances. Although, this can slightly cause a minor inconvenience in debugging, when users were trying to figure out why the transfer had failed.

Mitigation

# line 106 of Snow.sol
- i_weth.transfer(s_collector, collection);
+ bool success = i_weth.transfer(s_collector, collection);
+ require(success, "Fee collection failed!!!");
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge 3 days ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!