Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

Global earnTimer Enables Griefing Attacks and Unfair Token Distribution

Root + Impact

Description

The s_earnTimer is a single global variable shared by all users instead of being tracked per-user. This allows any user to reset the timer for everyone by calling either buySnow() or earnSnow(), preventing other users from earning their weekly Snow token. This creates an unfair distribution mechanism where users can grief others and monopolize the earning system.

The timer is reset globally whenever any user interacts with buySnow() or earnSnow(), forcing all other users to wait another week from that point.

// src/Snow.sol:30
uint256 private s_earnTimer; // @> Global timer for ALL users
// src/Snow.sol:87
function buySnow(uint256 amount) external payable canFarmSnow {
// ...
s_earnTimer = block.timestamp; // @> Resets timer for EVERYONE
// ...
}
// src/Snow.sol:92-99
function earnSnow() external canFarmSnow {
if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer(); // @> Checks GLOBAL timer
}
_mint(msg.sender, 1);
s_earnTimer = block.timestamp; // @> Resets timer for EVERYONE
}

Risk

Likelihood:

  • Any user calling earnSnow() or buySnow() resets the timer for all users

  • Attackers can intentionally call these functions to grief others

  • Normal protocol usage automatically causes griefing

  • No cost or barrier to performing this attack

Impact:

  • Users cannot earn their weekly Snow token on schedule

  • Malicious actors can prevent others from ever earning

  • Unfair token distribution favoring active griefers

  • First-mover advantage in each weekly period

  • Breaks the intended "1 Snow per week per user" mechanism

Proof of Concept

function testGriefingAttack() public {
// Timeline demonstration:
// T=0: Alice calls earnSnow() → gets 1 token, timer = 0
vm.prank(alice);
snow.earnSnow();
assertEq(snow.balanceOf(alice), 1);
// T=6 days: Bob tries to earn → REVERTS (timer not expired)
vm.warp(block.timestamp + 6 days);
vm.prank(bob);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
// T=7 days: Alice calls earnSnow() again → gets another token, timer = 7 days
vm.warp(block.timestamp + 1 days);
vm.prank(alice);
snow.earnSnow();
assertEq(snow.balanceOf(alice), 2);
// T=13 days: Bob tries again → STILL REVERTS (only 6 days since Alice's call)
vm.warp(block.timestamp + 6 days);
vm.prank(bob);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
// Bob can NEVER earn if Alice keeps calling every week!
// Griefing attack:
// Attacker can call buySnow(1) every 6 days to prevent everyone from earning
for (uint i = 0; i < 10; i++) {
vm.warp(block.timestamp + 6 days);
vm.prank(attacker);
snow.buySnow{value: snow.s_buyFee()}(1);
// Timer reset → all users must wait another week
}
}

Recommended Mitigation

- uint256 private s_earnTimer;
+ mapping(address => uint256) private s_earnTimer;
function buySnow(uint256 amount) external payable canFarmSnow {
uint256 totalCost = s_buyFee * amount;
if (msg.value > 0) {
require(msg.value == totalCost, "Incorrect ETH amount");
_mint(msg.sender, amount);
} else {
i_weth.safeTransferFrom(msg.sender, address(this), totalCost);
_mint(msg.sender, amount);
}
- s_earnTimer = block.timestamp;
+ s_earnTimer[msg.sender] = block.timestamp;
emit SnowBought(msg.sender, amount);
}
function earnSnow() external canFarmSnow {
- if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
+ if (s_earnTimer[msg.sender] != 0 && block.timestamp < (s_earnTimer[msg.sender] + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
- s_earnTimer = block.timestamp;
+ s_earnTimer[msg.sender] = block.timestamp;
+ emit SnowEarned(msg.sender, 1);
}
+ function getEarnTimer(address user) external view returns (uint256) {
+ return s_earnTimer[user];
+ }
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 4 hours ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!