Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

Global s_earnTimer Allows Single User to Block All Users from Earning

Root + Impact

Description

  • Normal behavior: Each user should have an independent weekly timer for earning free Snow tokens, allowing all users to earn once per week regardless of others' actions.

  • Specific issue: The s_earnTimer variable is global (not per-user). When any user calls buySnow() or earnSnow(), it resets the timer for ALL users, creating a denial-of-service vector.

// Root cause in src/Snow.sol:92-99 and line 87
function earnSnow() external canFarmSnow {
@> if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
@> s_earnTimer = block.timestamp; // Global timer reset affects ALL users!
}
function buySnow(uint256 amount) external payable canFarmSnow {
// ... minting logic ...
@> s_earnTimer = block.timestamp; // Also resets global timer!
emit SnowBought(msg.sender, amount);
}

Risk

Likelihood:

  • A griefer can repeatedly call buySnow(1) (paying minimal fee) to continuously reset the global timer

  • This blocks all other users from ever calling earnSnow() successfully

Impact:

  • Complete denial of service on the free token earning mechanism

  • Users who waited the full week are unfairly blocked

  • An attacker can grief the entire user base with minimal cost

Proof of Concept

The following test demonstrates that when a griefer calls buySnow, it resets the global s_earnTimer, which blocks all other users from calling earnSnow even if they have waited the required one week. User1 waits a full week but is still blocked because the griefer's action reset the timer.

function test_GlobalEarnTimerDoS() public {
address user1 = makeAddr("user1");
address griefer = makeAddr("griefer");
vm.warp(block.timestamp + 1 weeks);
// User1 earns snow successfully
vm.prank(user1);
snow.earnSnow();
assertEq(snow.balanceOf(user1), 1);
// Warp forward 1 week - user1 should be able to earn again
vm.warp(block.timestamp + 1 weeks);
// But griefer buys snow first - resets GLOBAL timer
uint256 buyFee = snow.s_buyFee();
vm.deal(griefer, buyFee);
vm.prank(griefer);
snow.buySnow{value: buyFee}(1);
// User1 is BLOCKED even though they waited 1 week!
vm.prank(user1);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow(); // REVERTS!
}

Recommended Mitigation

Change s_earnTimer from a single uint256 to a mapping(address => uint256) so each user has their own independent timer. Additionally, remove the timer reset from buySnow since purchasing tokens should not affect the free earning mechanism.

- uint256 private s_earnTimer;
+ mapping(address => uint256) private s_earnTimer;
function earnSnow() external canFarmSnow {
- if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
+ if (s_earnTimer[msg.sender] != 0 && block.timestamp < (s_earnTimer[msg.sender] + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
- s_earnTimer = block.timestamp;
+ s_earnTimer[msg.sender] = block.timestamp;
}
function buySnow(uint256 amount) external payable canFarmSnow {
// ... minting logic ...
- s_earnTimer = block.timestamp;
+ // Remove this line - buying should not affect earn timer
emit SnowBought(msg.sender, amount);
}
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge 1 day ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!