Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

`buySnow(0)` can block all users from earning free Snow

buySnow(0) can block all users from earning free Snow

Severity

Medium

Description

Snow.buySnow() does not reject zero amount purchases. If amount == 0 and msg.value == 0, the ETH payment branch succeeds because:

msg.value == (s_buyFee * amount)

evaluates to:

0 == 0

The function mints zero tokens, but still updates the global s_earnTimer:

s_earnTimer = block.timestamp;

earnSnow() uses this same global timer to decide whether anyone can earn free Snow:

if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer();
}

Affected code:

  • src/Snow.sol:79

  • src/Snow.sol:87

  • src/Snow.sol:93

Risk

Any address can call buySnow(0) for free and block all other users from earning free Snow for one week. The attacker can repeat this call to keep the free earning mechanism unavailable during the farming period.

Impact:

  • no-cost denial of service against earnSnow(),

  • all users share one global cooldown,

  • free weekly Snow distribution can be griefed for the whole protocol.

Proof of Concept

The PoC creates two arbitrary users: an attacker and a victim. The attacker calls buySnow(0) with no ETH and no WETH. This mints zero Snow but updates s_earnTimer. Immediately after, the victim attempts to call earnSnow() and the call reverts with S__Timer.

Add this test to test/AuditFuzz.t.sol:

function testFuzz_ZeroAmountBuySnowBlocksOtherUsersFromEarning(address attacker, address victim) public {
vm.assume(attacker != address(0));
vm.assume(victim != address(0));
vm.assume(attacker != victim);
MockWETH weth = new MockWETH();
Snow snow = new Snow(address(weth), 5, makeAddr("collector"));
vm.warp(1 days);
vm.prank(attacker);
snow.buySnow(0);
vm.prank(victim);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
}

Run:

forge test --match-test testFuzz_ZeroAmountBuySnowBlocksOtherUsersFromEarning --fuzz-runs 10000 -vvv

Result:

[PASS] testFuzz_ZeroAmountBuySnowBlocksOtherUsersFromEarning(address,address) (runs: 10000)

The test proves arbitrary attacker/victim pairs can trigger the denial of service.

Mitigation

Reject zero amount purchases:

function buySnow(uint256 amount) external payable canFarmSnow {
if (amount == 0) revert S__ZeroValue();
...
}

Also consider changing the earn cooldown to be per-user:

mapping(address => uint256) private s_lastEarnedAt;
function earnSnow() external canFarmSnow {
if (s_lastEarnedAt[msg.sender] != 0 && block.timestamp < s_lastEarnedAt[msg.sender] + 1 weeks) {
revert S__Timer();
}
_mint(msg.sender, 1);
s_lastEarnedAt[msg.sender] = block.timestamp;
}
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 4 hours ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!