Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

Global s_earnTimer variable causes complete Denial of Service (DoS) for all free token claims

Root + Impact

Description

  • The protocol intends to allow every individual user to claim one free Snow token per week via the earnSnow() function, using a cooldown timer to prevent spam.

  • The s_earnTimer state variable used to enforce this cooldown is implemented as a single, global uint256 rather than a user-specific mapping. Because of this, the timer is globally overwritten every time any user calls earnSnow() or buySnow(), permanently bricking the claim mechanic for the rest of the entire user base.

uint256 private s_earnTimer; // @> BUG: This is a global variable, not tied to a user
function earnSnow() external canFarmSnow {
if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
s_earnTimer = block.timestamp; // @> BUG: Overwrites the global timer for ALL users
}
function buySnow(uint256 amount) external payable canFarmSnow {
// ... transfer logic ...
s_earnTimer = block.timestamp; // @> BUG: Any token purchase resets the free-claim timer for everyone
}

Risk

Likelihood:

  • Occurs immediately after the very first user successfully claims a free token.

  • Occurs immediately every time any user purchases a token using ETH or WETH.

Impact:

  • Complete Denial of Service (DoS) of the free token farming mechanic.

  • Loss of core protocol functionality, making it mathematically impossible for the user base to earn tokens as advertised.

Proof of Concept

Narrative Setup: The following Foundry test proves that a single user interacting with the protocol permanently blocks all other users from utilizing the earnSnow() mechanic.

Execution Steps:

  1. We simulate a normal user (Ashley) claiming her free weekly token.

  2. We advance the blockchain time by 1 day.

  3. We simulate a completely new user (Jerry) attempting to claim a token.

  4. The test expects Jerry's transaction to revert with S__Timer(), proving he is blocked by Ashley's action.

  5. The second test proves that purchasing tokens via buySnow also globally resets the timer for free claims.

How to run this test: Place the following code inside the protocol's existing TestSnow.t.sol file and execute: forge test --match-test test_POC_ -vvv

function test_POC_GlobalTimerBlocksOtherUsers() public {
// 1. Ashley claims her free weekly token.
// This sets the GLOBAL s_earnTimer to block.timestamp.
vm.prank(ashley);
snow.earnSnow();
// 2. Fast forward 1 day.
// A different user, Jerry, wants to claim his free token.
// He has NEVER claimed a token before.
vm.warp(block.timestamp + 1 days);
// 3. Jerry attempts to claim, but the transaction reverts.
// The global timer forces Jerry to wait 1 week after ASHLEY'S claim.
vm.prank(jerry);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
console2.log("Ashley balance:", snow.balanceOf(ashley));
console2.log("Jerry balance:", snow.balanceOf(jerry));
console2.log("BUG: Jerry is completely blocked from claiming!");
}
function test_POC_BuyResetsGlobalTimer() public {
// 1. Victory buys a token using ETH.
// In Snow.sol, buySnow() updates the GLOBAL s_earnTimer.
vm.prank(victory);
snow.buySnow{value: FEE}(1);
// 2. Fast forward 6 days. Ashley tries to claim her free token.
vm.warp(block.timestamp + 6 days);
// 3. Ashley's claim reverts because Victory's purchase reset the timer
// for the entire protocol.
vm.prank(ashley);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
}

Recommended Mitigation

Architectural Fix: To enforce a per-user cooldown, the state architecture must be changed from a single global variable to a mapping. This ensures every address has its own independent timer state.

Additionally, the state update inside buySnow() must be completely removed. Purchasing a token should have no mechanical link to the free-claim cooldown timer.

This fix adds a negligible amount of gas overhead (standard SSTORE mapping costs) but fundamentally restores the core business logic of the protocol.


- uint256 private s_earnTimer;
+ mapping(address => uint256) private s_earnTimers;
function earnSnow() external canFarmSnow {
- if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
+ if (s_earnTimers[msg.sender] != 0 && block.timestamp < (s_earnTimers[msg.sender] + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
- s_earnTimer = block.timestamp;
+ s_earnTimers[msg.sender] = block.timestamp;
}
function buySnow(uint256 amount) external payable canFarmSnow {
if (msg.value == (s_buyFee * amount)) {
_mint(msg.sender, amount);
} else {
i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount));
_mint(msg.sender, amount);
}
- s_earnTimer = block.timestamp;
}
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 2 hours ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!