Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

M-01 Shared Global Timer in earnSnow()

Root + Impact

Description

  • Normal behavior: Each user should be able to earn 1 token per week independently using their own cooldown timer (per-user mechanism).

  • Issue: The contract uses a single global state variable s_earnTimer shared by all users. When any user calls earnSnow(), the timer resets for everyone, preventing other users from earning even though they haven't earned recently.

// src/Snow.sol:30 - Single global timer shared by ALL users
@> uint256 private s_earnTimer;
// src/Snow.sol:92-99 - Timer check affects all users globally
function earnSnow() external canFarmSnow {
if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
@> s_earnTimer = block.timestamp; // Timer resets for EVERYONE
}
// src/Snow.sol:87 - buySnow() also resets global timer
@> s_earnTimer = block.timestamp; // Also resets global timer!

Risk

Likelihood:

  • Any multi-user activity where one user calls earnSnow() before others in the same week

  • The timer resets with every earnSnow() or buySnow() call, affecting all users

Impact:

  • Users cannot predictably earn their 1 token/week entitlement

  • A single user calling earnSnow() early in a week blocks all other users for ~7 days

  • Protocol's intended "1 token per user per week" mechanism is completely broken

Proof of Concept

This POC shows how the global s_earnTimer blocks all users when one user calls earnSnow(), violating the intended per-user cooldown mechanism.

// From test/audit/M-01-logic-global-timer.t.sol
function testOneUserBlocksOthers() public {
// Alice earns at T=0
vm.prank(alice);
snow.earnSnow();
assertEq(snow.balanceOf(alice), 1);
// Bob tries to earn at T=1 day - should fail due to global timer
vm.warp(block.timestamp + 1 days);
vm.prank(bob);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
// Charlie also blocked
vm.prank(charlie);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
}
function testProtocolIntentViolation() public {
// Protocol intent: "Each user can earn 1 token/week independently"
// Actual result: "Only 1 user globally can earn per week"
vm.prank(alice);
snow.earnSnow();
vm.warp(block.timestamp + 6 days);
vm.prank(bob);
vm.expectRevert(Snow.S__Timer.selector); // Blocked by Alice
snow.earnSnow();
vm.warp(block.timestamp + 1 weeks);
vm.prank(bob);
snow.earnSnow(); // Now works, but resets timer
vm.warp(block.timestamp + 6 days);
vm.prank(charlie);
vm.expectRevert(Snow.S__Timer.selector); // Blocked by Bob
snow.earnSnow();
}

Recommended Mitigation

Replacing the global timer with a per-user mapping allows each user to have their own independent cooldown, restoring the intended "1 token per user per week" mechanism.

// src/Snow.sol:30 - Replace global timer with per-user mapping
- uint256 private s_earnTimer;
+ mapping(address => uint256) private s_userLastEarnTime;
// src/Snow.sol:92-99 - Update earnSnow() to use per-user timer
function earnSnow() external canFarmSnow {
- if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
+ if (s_userLastEarnTime[msg.sender] != 0 &&
+ block.timestamp < (s_userLastEarnTime[msg.sender] + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
- s_earnTimer = block.timestamp;
+ s_userLastEarnTime[msg.sender] = block.timestamp;
}
// src/Snow.sol:87 - Remove or handle timer update in buySnow() separately
- s_earnTimer = block.timestamp;
+ // Remove or handle separately if buySnow needs different logic
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge 8 days ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!