Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

Repeatable Airdrop Claims

Root + Impact

Description

  • Normal behavior: Each eligible receiver should claim once, transferring their Snow to the airdrop and receiving the corresponding Snowman NFTs.

  • Issue: The contract records `s_hasClaimedSnowman` but never checks it, so a whitelisted receiver can reacquire Snow and claim again with the same Merkle proof and a fresh signature.

// src/SnowmanAirdrop.sol:47-99
@> mapping(address => bool) private s_hasClaimedSnowman;
...
@> function claimSnowman(address receiver, bytes32[] calldata merkleProof, uint8 v, bytes32 r, bytes32 s)
@> external
@> nonReentrant
@> {
@> ...
@> s_hasClaimedSnowman[receiver] = true;
@> ...
@> i_snowman.mintSnowman(receiver, amount);
@> }

Risk

Likelihood:

  • Eligible receivers can reacquire Snow via `buySnow` during the farming window and submit another claim.

  • Each repeat claim is authorized by a new signature over the receiver's current balance, which the contract accepts.

Impact:

  • NFT supply inflates beyond the intended allocation for eligible addresses.

  • Distribution integrity and fairness of the airdrop is reduced.

Proof of Concept

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.24;
import {Test} from "forge-std/Test.sol";
import {Snow} from "../../src/Snow.sol";
import {Snowman} from "../../src/Snowman.sol";
import {SnowmanAirdrop} from "../../src/SnowmanAirdrop.sol";
import {Helper} from "../../script/Helper.s.sol";
contract PocRepeatClaim is Test {
Snow snow;
Snowman nft;
SnowmanAirdrop airdrop;
Helper deployer;
bytes32 alProofA = 0xf99782cec890699d4947528f9884acaca174602bb028a66d0870534acf241c52;
bytes32 alProofB = 0xbc5a8a0aad4a65155abf53bb707aa6d66b11b220ecb672f7832c05613dba82af;
bytes32 alProofC = 0x971653456742d62534a5d7594745c292dda6a75c69c43a6a6249523f26e0cac1;
bytes32[] AL_PROOF = [alProofA, alProofB, alProofC];
address alice;
uint256 aliceKey;
address gasPayer;
function setUp() public {
deployer = new Helper();
(airdrop, snow, nft,) = deployer.run();
(alice, aliceKey) = makeAddrAndKey("alice");
gasPayer = makeAddr("gas_payer");
}
function _claimOnce() internal {
vm.prank(alice);
snow.approve(address(airdrop), 1);
bytes32 digest = airdrop.getMessageHash(alice);
(uint8 v, bytes32 r, bytes32 s) = vm.sign(aliceKey, digest);
vm.prank(gasPayer);
airdrop.claimSnowman(alice, AL_PROOF, v, r, s);
}
function testRepeatClaimAllowed() public {
_claimOnce();
assertEq(nft.balanceOf(alice), 1);
uint256 fee = snow.s_buyFee();
deal(alice, fee);
vm.prank(alice);
snow.buySnow{value: fee}(1);
_claimOnce();
assertEq(nft.balanceOf(alice), 2);
}
function testFuzz_RepeatClaimAllowed(uint8 totalClaims) public {
totalClaims = uint8(bound(totalClaims, 1, 3));
_claimOnce();
assertEq(nft.balanceOf(alice), 1);
if (totalClaims > 1) {
uint256 fee = snow.s_buyFee();
deal(alice, fee * (totalClaims - 1));
for (uint256 i = 1; i < totalClaims; i++) {
vm.prank(alice);
snow.buySnow{value: fee}(1);
_claimOnce();
}
}
assertEq(nft.balanceOf(alice), totalClaims);
}
}

Recommended Mitigation

+ error SA__AlreadyClaimed();
@@
function claimSnowman(address receiver, bytes32[] calldata merkleProof, uint8 v, bytes32 r, bytes32 s)
external
nonReentrant
{
+ if (s_hasClaimedSnowman[receiver]) {
+ revert SA__AlreadyClaimed();
+ }
...
}
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge 1 day ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-01] Missing Claim Status Check Allows Multiple Claims in SnowmanAirdrop.sol::claimSnowman

# Root + Impact &#x20; **Root:** The [`claimSnowman`](https://github.com/CodeHawks-Contests/2025-06-snowman-merkle-airdrop/blob/b63f391444e69240f176a14a577c78cb85e4cf71/src/SnowmanAirdrop.sol#L44) function updates `s_hasClaimedSnowman[receiver] = true` but never checks if the user has already claimed before processing the claim, allowing users to claim multiple times if they acquire more Snow tokens. **Impact:** Users can bypass the intended one-time airdrop limit by claiming, acquiring more Snow tokens, and claiming again, breaking the airdrop distribution model and allowing unlimited NFT minting for eligible users. ## Description * **Normal Behavior:** Airdrop mechanisms should enforce one claim per eligible user to ensure fair distribution and prevent abuse of the reward system. * **Specific Issue:** The function sets the claim status to true after processing but never validates if `s_hasClaimedSnowman[receiver]` is already true at the beginning, allowing users to claim multiple times as long as they have Snow tokens and valid proofs. ## Risk **Likelihood**: Medium * Users need to acquire additional Snow tokens between claims, which requires time and effort * Users must maintain their merkle proof validity across multiple claims * Attack requires understanding of the missing validation check **Impact**: High * **Airdrop Abuse**: Users can claim far more NFTs than intended by the distribution mechanism * **Unfair Distribution**: Some users receive multiple rewards while others may receive none * **Economic Manipulation**: Breaks the intended scarcity and distribution model of the NFT collection ## Proof of Concept Add the following test to TestSnowMan.t.sol  ```Solidity function testMultipleClaimsAllowed() public { // Alice claims her first NFT vm.prank(alice); snow.approve(address(airdrop), 1); bytes32 aliceDigest = airdrop.getMessageHash(alice); (uint8 v, bytes32 r, bytes32 s) = vm.sign(alKey, aliceDigest); vm.prank(alice); airdrop.claimSnowman(alice, AL_PROOF, v, r, s); assert(nft.balanceOf(alice) == 1); assert(airdrop.getClaimStatus(alice) == true); // Alice acquires more Snow tokens (wait for timer and earn again) vm.warp(block.timestamp + 1 weeks); vm.prank(alice); snow.earnSnow(); // Alice can claim AGAIN with new Snow tokens! vm.prank(alice); snow.approve(address(airdrop), 1); bytes32 aliceDigest2 = airdrop.getMessageHash(alice); (uint8 v2, bytes32 r2, bytes32 s2) = vm.sign(alKey, aliceDigest2); vm.prank(alice); airdrop.claimSnowman(alice, AL_PROOF, v2, r2, s2); // Second claim succeeds! assert(nft.balanceOf(alice) == 2); // Alice now has 2 NFTs } ``` ## Recommended Mitigation **Add a claim status check at the beginning of the function** to prevent users from claiming multiple times. ```diff // Add new error + error SA__AlreadyClaimed(); function claimSnowman(address receiver, bytes32[] calldata merkleProof, uint8 v, bytes32 r, bytes32 s) external nonReentrant { + if (s_hasClaimedSnowman[receiver]) { + revert SA__AlreadyClaimed(); + } + if (receiver == address(0)) { revert SA__ZeroAddress(); } // Rest of function logic... s_hasClaimedSnowman[receiver] = true; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!