Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

Global `s_earnTimer` restricts free Snow earning to only one user per week instead of per-user

Description:

The Snow contract is designed to allow each user to earn one free Snow token per week via the earnSnow() function. However, the timer that enforces the 1-week cooldown is stored in a single global variable s_earnTimer rather than a per-user mapping. This means when any single user earns Snow, the cooldown is applied to ALL users system-wide. Only one address can earn free Snow per week, and all other users are blocked regardless of whether they have ever earned before.

uint256 private s_earnTimer; @> // Single global variable shared by all users
function earnSnow() external canFarmSnow {
if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer(); @> // Blocks EVERYONE, not just the caller
}
_mint(msg.sender, 1);
s_earnTimer = block.timestamp; @> // First caller resets timer for all users
}

Risk:

Likelihood:

This occurs every time any user calls earnSnow() — the very first caller each week locks out all other users for 7 full days.

In any deployment with more than one user, this will affect the majority of users who try to earn after the first weekly claim.

#Impact:

Only 1 out of all users can earn free Snow each week, making the "earn once a week" feature completely non-functional for the vast majority of participants.

Users who are unable to earn Snow cannot participate in the airdrop unless they buy Snow with ETH/WETH, creating an unfair economic barrier.

Proof of Concept:

cat > test/PoC4_BuyResetsEarnTimer.t.sol << 'EOF'
// SPDX-License-Identifier: MIT
pragma solidity ^0.8.24;
import {Test, console2} from "forge-std/Test.sol";
import {Snow} from "../src/Snow.sol";
import {DeploySnow} from "../script/DeploySnow.s.sol";
import {MockWETH} from "../src/mock/MockWETH.sol";
contract PoC4_BuyResetsEarnTimer is Test {
Snow snow;
MockWETH weth;
uint256 FEE;
address alice = makeAddr("alice");
address attacker = makeAddr("attacker");
function setUp() public {
DeploySnow deployer = new DeploySnow();
snow = deployer.run();
weth = deployer.weth();
FEE = deployer.FEE();
weth.mint(attacker, FEE * 100);
deal(attacker, FEE * 100);
}
function testBuySnowResetsEarnTimerForEveryone() public {
// Alice earns free Snow
vm.prank(alice);
snow.earnSnow();
assertEq(snow.balanceOf(alice), 1);
console2.log("Alice earned free Snow");
// Attacker buys Snow with ETH, resetting the global timer
vm.prank(attacker);
snow.buySnow{value: FEE}(1);
console2.log("Attacker bought Snow, resetting s_earnTimer");
// Alice waits 1 week and earns again
vm.warp(block.timestamp + 1 weeks);
vm.prank(alice);
snow.earnSnow();
assertEq(snow.balanceOf(alice), 2);
console2.log("Alice earned again after 1 week");
// Attacker buys 6 days later, resetting timer again
vm.warp(block.timestamp + 6 days);
vm.prank(attacker);
snow.buySnow{value: FEE}(1);
console2.log("Attacker bought Snow again, resetting timer");
// Alice tries to earn after 2 weeks total - BLOCKED
// because attacker's buy reset the timer just 1 day ago
vm.warp(block.timestamp + 1 days);
vm.prank(alice);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
console2.log("Alice BLOCKED from earning even after 2 weeks total");
}
function testPermanentDoSOnEarnSnow() public {
// Alice earns once
vm.prank(alice);
snow.earnSnow();
// Attacker permanently DoS by buying every 6 days
for (uint256 i = 0; i < 10; i++) {
vm.warp(block.timestamp + 6 days);
vm.prank(attacker);
snow.buySnow{value: FEE}(1);
}
console2.log("Attacker bought 10 times over 60 days");
// Bob tries to earn - BLOCKED
vm.prank(makeAddr("bob"));
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow();
console2.log("Bob BLOCKED - earnSnow permanently DoSed");
}
}
EOF
forge test --match-contract PoC4_BuyResetsEarnTimer -vvv

Recommended Mitigation:

Replace the global s_earnTimer with a per-user mapping so each user has their own independent cooldown:

- uint256 private s_earnTimer;
+ mapping(address => uint256) private s_earnTimer;
function earnSnow() external canFarmSnow {
- if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
+ if (s_earnTimer[msg.sender] != 0 && block.timestamp < (s_earnTimer[msg.sender] + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
- s_earnTimer = block.timestamp;
+ s_earnTimer[msg.sender] = block.timestamp;
}

Also apply the same fix to buySnow() which incorrectly resets the global timer (see separate finding).

Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 2 hours ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!