Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

Global `s_earnTimer` cooldown in `Snow` allows anyone to zero-cost DoS `earnSnow()` for all users

Root + Impact

Description

  • Users are meant to earn one free Snow once per week during the 12-week farming window, with the cooldown applying per user.

  • The cooldown is a single global s_earnTimer written by both buySnow() and earnSnow(), so any call by any user resets the shared timer and blocks the free-claim path for everyone else.

uint256 private s_earnTimer; // @> global, should be a per-user mapping
​
function buySnow(uint256 amount) external payable canFarmSnow {
// ...
s_earnTimer = block.timestamp; // @> any purchase resets the cooldown for everyone
}
​
function earnSnow() external canFarmSnow {
if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) { // @> checks the shared timer
revert S__Timer();
}
_mint(msg.sender, 1);
s_earnTimer = block.timestamp; // @> one earn blocks the whole network for a week
}

Risk

Likelihood:

  • buySnow(0) with msg.value == 0 satisfies msg.value == (s_buyFee * 0), mints nothing, yet still writes s_earnTimer — a griefer resets the timer at zero cost, repeatable for the entire 12 weeks.

  • Normal usage also triggers it: every buySnow() or earnSnow() by any user locks out all others for a week.

Impact:

  • Permanent DoS of earnSnow() — no user can claim free Snow while the griefer keeps resetting.

  • The per-user "once a week" feature is mathematically impossible: the whole network gets at most ~1 free Snow per week (~12 total over the farming duration), breaking the free eligibility path to the NFT airdrop.

Proof of Concept

forge test --mt test_Audit_GlobalEarnTimerGriefing -vvv

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.24;
​
import {Test} from "forge-std/Test.sol";
import {Snow} from "../src/Snow.sol";
import {MockWETH} from "../src/mock/MockWETH.sol";
​
contract AuditPoC_H2 is Test {
Snow snow;
address griefer = makeAddr("griefer");
address victim = makeAddr("victim");
​
function setUp() public {
snow = new Snow(address(new MockWETH()), 5, makeAddr("collector"));
}
​
function test_Audit_GlobalEarnTimerGriefing() public {
vm.prank(victim);
snow.earnSnow(); // sets the GLOBAL timer
assertEq(snow.balanceOf(victim), 1);
​
vm.warp(block.timestamp + 1 weeks + 1); // a full week passes for the victim
​
// zero-cost reset: amount=0, msg.value=0 == s_buyFee*0 → ETH branch, mints 0
vm.prank(griefer);
snow.buySnow{value: 0}(0);
​
vm.prank(victim);
vm.expectRevert(Snow.S__Timer.selector);
snow.earnSnow(); // reverts although a full week passed for the victim
}
}

Recommended Mitigation

- uint256 private s_earnTimer;
+ mapping(address => uint256) private s_lastEarnTimestamp;
​
function buySnow(uint256 amount) external payable canFarmSnow {
- s_earnTimer = block.timestamp;
+ // remove: buying must not reset the earn cooldown
}
​
function earnSnow() external canFarmSnow {
- if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
+ if (s_lastEarnTimestamp[msg.sender] != 0
+ && block.timestamp < s_lastEarnTimestamp[msg.sender] + 1 weeks) {
revert S__Timer();
}
_mint(msg.sender, 1);
- s_earnTimer = block.timestamp;
+ s_lastEarnTimestamp[msg.sender] = block.timestamp;
}

Optionally add if (amount == 0) revert S__ZeroValue(); to buySnow() to block no-op calls.

Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 1 hour ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!