Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

Snow weekly earn timer is global, not per user, so one earn or purchase blocks every other user for a week

Root + Impact

Description

// src/Snow.sol - a single shared timer gates the weekly free earn
@> uint256 private s_earnTimer;
@> function earnSnow() external {
@> if (block.timestamp < s_earnTimer + 1 weeks) {
@> revert S__Timer();
@> }
@> s_earnTimer = block.timestamp;
@> _mint(msg.sender, 1);
@> }
​
s_earnTimer is one state variable shared by every user, not a mapping keyed by address. The README says Snow can be earned for free once a week, which reads as once a week per user. In practice the first user to call earnSnow() starts a one-week lockout for everyone, and any buySnow() call restarts the timer too, because buySnow() also writes s_earnTimer = block.timestamp.
​
Impact: the advertised free earn is effectively unavailable once more than one user is involved. The project's own test setup has to warp one week forward between each user's earn (script/Helper.s.sol earns for aliceSB, bobSB, carolSB, danaSB and eveSB separated by vm.warp(block.timestamp + 1 weeks)), which shows the authors treated the limit as per user. Worse, anyone can call buySnow(0) with no ether: msg.value == s_buyFee * 0 is true, 0 Snow is minted, and the timer is still reset, so the free earn can be kept locked indefinitely at zero cost.

Risk

Likelihood:

Impact:

Proof of Concept

// Steps to reproduce (manual trace against src/Snow.sol):
// 1. Deploy as in script/DeploySnow.s.sol (buyFee 5 ether, duration 4 weeks).
// 2. Alice calls earnSnow() and receives 1 Snow.
// 3. In the same week Bob calls earnSnow() - it reverts with S__Timer(),
// even though Bob has never earned before.
// 4. After warping one week forward, Carol calls buySnow(1) with 5 ether.
// 5. Dave now calls earnSnow() - it reverts again, because buySnow()
// also wrote s_earnTimer.
// 6. Griefing variant: anyone can call buySnow(0) with 0 ether. The
// condition msg.value == s_buyFee * 0 is true, 0 Snow is minted, and
// s_earnTimer is still reset, blocking earnSnow() for another week
// at zero cost. Repeating the free call keeps the earn locked forever.
// The project's own tests only test one user earning at a time
// (test/TestSnow.t.sol, testCanEarnSnow), so this is untested.

Recommended Mitigation

- uint256 private s_earnTimer;
+ mapping(address user => uint256 lastEarn) private s_earnTimer;
- if (block.timestamp < s_earnTimer + 1 weeks) {
+ if (block.timestamp < s_earnTimer[msg.sender] + 1 weeks) {
- s_earnTimer = block.timestamp;
+ s_earnTimer[msg.sender] = block.timestamp;
​
Also remove the s_earnTimer = block.timestamp line from buySnow(), so buying Snow never affects the free earn, and add a check that amount is greater than zero in buySnow().
Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 2 hours ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!