Snowman Merkle Airdrop

AI First Flight #10
Beginner FriendlyFoundrySolidityNFT
EXP
View results
Submission Details
Severity: low
Valid

s_earnTimer is a single global variable — the weekly free Snow claim is first-come-first-served for the whole contract

Root + Impact

The Snow contract is supposed to let every holder earn one Snow token for free, once per week. But the weekly timer is stored in a single global uint256 private s_earnTimer; shared by all users, instead of a per-address mapping. As a result, the moment any one user calls earnSnow() (or even just buySnow()), the timer resets for everyone, and every other user gets revert S__Timer() until a full week passes.

Description

// Root cause in the codebase with @> marks to highlight the relevant section
// Snow.sol — line 30
@> uint256 private s_earnTimer; // ONE timer for the entire contract
​
// line 92
function earnSnow() external canFarmSnow {
@> if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
@> s_earnTimer = block.timestamp; // overwrites the timer for everyone
}
​

//

buySnow() also writes s_earnTimer = block.timestamp; (line 87), so even a single purchase blocks every other user from their free weekly claim. In practice, only the one user who happens to call first each week ever gets the free Snow; the rest of the community is locked out. The core "earn weekly for free" feature is broken for everyone but the first caller.

Risk

Likelihood: High — any two users claiming in the same week trigger it; no special setup needed.

Impact: High — the free weekly Snow claim is the protocol's main acquisition loop; it silently works for one user and fails for all others.

Proof of Concept

userB's earnSnow() reverts immediately after userA claims, because s_earnTimer is one shared value. Each user needs their own timer.


// SPDX-License-Identifier: MIT
pragma solidity ^0.8.24;
​
import {Test} from "forge-std/Test.sol";
import {Snow} from "../src/Snow.sol";
import {MockWETH} from "../src/mock/MockWETH.sol";
​
contract PoC is Test {
Snow snow;
address userA = address(0xA);
address userB = address(0xB);
​
function setUp() public {
snow = new Snow(address(new MockWETH()), 5, address(0xC));
}
​
function test_earnSnow_timer_is_global_not_per_user() public {
vm.prank(userA);
snow.earnSnow(); // A claims at time T — sets the global timer
​
vm.prank(userB);
snow.earnSnow(); // B claims in the same week
// EXPECTED: succeeds (B has their own free claim)
// ACTUAL: reverts S__Timer() — A's claim blocked B
}
}
​

Recommended

Replace the global timer with a per-user mapping so every holder has an independent weekly claim:

- uint256 private s_earnTimer;
+ mapping(address => uint256) private s_earnTimer;
diff
function earnSnow() external canFarmSnow {
- if (s_earnTimer != 0 && block.timestamp < (s_earnTimer + 1 weeks)) {
+ uint256 last = s_earnTimer[msg.sender];
+ if (last != 0 && block.timestamp < (last + 1 weeks)) {
revert S__Timer();
}
_mint(msg.sender, 1);
- s_earnTimer = block.timestamp;
+ s_earnTimer[msg.sender] = block.timestamp;
}
​

And update the write in buySnow():

- s_earnTimer = block.timestamp;
+ s_earnTimer[msg.sender] = block.timestamp;
​

Now each user tracks their own last-claim/purchase time and can earn free Snow weekly regardless of what other users do.

Updates

Lead Judging Commences

ai-first-flight-judge Lead Judge about 4 hours ago
Submission Judgement Published
Validated
Assigned finding tags:

[L-02] Global Timer Reset in Snow::buySnow Denies Free Claims for All Users

## Description: The `Snow::buySnow` function contains a critical flaw where it resets a global timer `(s_earnTimer)` to the current block timestamp on every invocation. This timer controls eligibility for free token claims via `Snow::earnSnow()`, which requires 1 week to pass since the last timer reset. As a result: Any token purchase `(via buySnow)` blocks all free claims for all users for 7 days Malicious actors can permanently suppress free claims with micro-transactions Contradicts protocol documentation promising **"free weekly claims per user"** ## Impact: * **Complete Denial-of-Service:** Free claim mechanism becomes unusable * **Broken Protocol Incentives:** Undermines core user acquisition strategy * **Economic Damage:** Eliminates promised free distribution channel * **Reputation Harm:** Users perceive protocol as dishonest ```solidity function buySnow(uint256 amount) external payable canFarmSnow { if (msg.value == (s_buyFee * amount)) { _mint(msg.sender, amount); } else { i_weth.safeTransferFrom(msg.sender, address(this), (s_buyFee * amount)); _mint(msg.sender, amount); } @> s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` ## Risk **Likelihood**: • Triggered by normal protocol usage (any purchase) • Requires only one transaction every 7 days to maintain blockage • Incentivized attack (low-cost disruption) **Impact**: • Permanent suppression of core protocol feature • Loss of user trust and adoption • Violates documented tokenomics ## Proof of Concept **Attack Scenario:** Permanent Free Claim Suppression * Attacker calls **buySnow(1)** with minimum payment * **s\_earnTimer** sets to current timestamp (T0) * All **earnSnow()** calls revert for **next 7 days** * On day 6, attacker repeats **buySnow(1)** * New timer reset (T1 = T0+6 days) * Free claims blocked until **T1+7 days (total 13 days)** * Repeat step **4 every 6 days → permanent blockage** **Test Case:** ```solidity // Day 0: Deploy contract snow = new Snow(...); // s_earnTimer = 0 // UserA claims successfully snow.earnSnow(); // Success (first claim always allowed) // Day 1: UserB buys 1 token snow.buySnow(1); // Resets global timer to day 1 // Day 2: UserA attempts claim snow.earnSnow(); // Reverts! Requires day 1+7 = day 8 // Day 7: UserC buys 1 token (day 7 < day 1+7) snow.buySnow(1); // Resets timer to day 7 // Day 8: UserA retries snow.earnSnow(); // Still reverts! Now requires day 7+7 = day 14 ``` ## Recommended Mitigation **Step 1:** Remove Global Timer Reset from `buySnow` ```diff function buySnow(uint256 amount) external payable canFarmSnow { // ... existing payment logic ... - s_earnTimer = block.timestamp; emit SnowBought(msg.sender, amount); } ``` **Step 2:** Implement Per-User Timer in `earnSnow` ```solidity // Add new state variable mapping(address => uint256) private s_lastClaimTime; function earnSnow() external canFarmSnow { // Check per-user timer instead of global if (s_lastClaimTime[msg.sender] != 0 && block.timestamp < s_lastClaimTime[msg.sender] + 1 weeks ) { revert S__Timer(); } _mint(msg.sender, 1); s_lastClaimTime[msg.sender] = block.timestamp; // Update user-specific timer emit SnowEarned(msg.sender, 1); // Add missing event } ``` **Step 3:** Initialize First Claim (Constructor) ```solidity constructor(...) { // Initialize with current timestamp to prevent immediate claims s_lastClaimTime[address(0)] = block.timestamp; } ```

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!