Submission Details
Severity:
The constant variable FEED_PRECISION is defined but not used
Summary
In the protocol, the variable FEED_PRECISION is declared as 10^8, which equates to 1 BTC = 10^8 but is not used in code.
Vulnerability Details
The variable FEED_PRECISIONis declared but not used.
It is my assuption that value should be use in functions _get_usd_value and _get_token_amount_from_usdas a normalizer for BTC and ETH implementation.
Impact
**Low vulnerability in the scope of gas consumption. **
Medium vulnerability because the _get_usd_value and _get_token_amount_from_usd parameters lack proper implementation for BTC and ETH.
Tools Used
manual review
Recommendations
Please rething protocol.
Consider this equation:
(usd_amount_in_wei * PRECISION) // (convert(price, uint256) * ADDITIONAL_FEED_PRECISION)
// @audit usd_amount_in_wei*10^18 / price*10,000,000,000 and if ETH * FEED_PRECISION
Rewards breakdown
This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.