Precision loss in fee calculation due to division before multiplication
The getCalculatedFee function divides the product of amount and token price by s_feePrecision before multiplying it by s_flashLoanFee. This division before multiplication truncates the intermediate result. For small borrow amounts, this can cause the calculated fee to round down to zero, allowing users to bypass flash loan fees.
Lead Judging Commences
[L-01] getCalculatedFee can be 0
## Description getCalculatedFee can be as low as 0 ## Vulnerability Details Any value up to 333 for "amount" can result in 0 fee based on calculation ``` function testFuzzGetCalculatedFee() public { AssetToken asset = thunderLoan.getAssetFromToken(tokenA); uint256 calculatedFee = thunderLoan.getCalculatedFee( tokenA, 333 ); assertEq(calculatedFee ,0); console.log(calculatedFee); } ``` ## Impact Low as this amount is really small ## Recommendations A minimum fee can be used to offset the calculation, though it is not that important.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Judging
Submissions are being reviewed by our AI judge. Results will be available in a few minutes.
View all submissionsRewards Distribution
The contest is complete and the rewards are being distributed.