Submission Details
Severity:
Repay may revert in 0 amount transfer
Summary
Repay may revert in situation 0 amount transfer when transferring specifically loan token to the fee receiver.
Vulnerability Details
In repay(uint256[] calldata loanIds)
function repay(uint256[] calldata loanIds) public {
for (uint256 i = 0; i < loanIds.length; i++) {
…
// transfer the protocol fee to the fee receiver
IERC20(loan.loanToken).transferFrom(
msg.sender,
feeReceiver,
protocolInterest
);
…
}
}
There is no check whether protocolInterest is 0, some erc20 will revert on 0 value transfer.
In this situation, repay will revert.
Impact
Repay may not work properly on 0 protocolInterest transfer.
Tools Used
Manual Review
Recommendations
Add zero value check before transfer
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.