Submission Details
Severity:
Fees.sol#L30-L40 : Lack of slippage protection for uniswap swapping.
Summary
Fees.sol has the sellProfits function which will take the contracts balance and tries to swap and get the amount and then transfer to the staking contract.
the issue here is, there is no protection from MEV bots and other price manipulation attack which will lead to loss of funds. This is because there is not protection from slippage issue.
Vulnerability Details
function sellProfits(address _profits) public {
require(_profits != WETH, "not allowed");
uint256 amount = IERC20(_profits).balanceOf(address(this));
ISwapRouter.ExactInputSingleParams memory params = ISwapRouter
.ExactInputSingleParams({
tokenIn: _profits,
tokenOut: WETH,
fee: 3000,
recipient: address(this),
deadline: block.timestamp,
amountIn: amount,
amountOutMinimum: 0, -------------->>> audit find . no min value is specified.
sqrtPriceLimitX96: 0
});
amount = swapRouter.exactInputSingle(params);
IERC20(WETH).transfer(staking, IERC20(WETH).balanceOf(address(this)));
}
}
Impact
Loss of funds due to MEV bots attack or price manipulation attacks.
Tools Used
Manual review.
Recommendations
Include the slippage value this would ensure that the loss would not go beyond this specified limit.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.