Submission Details
Severity:
Staking.sol#L53 : Re-entrancy problem in claim call
Summary
During claim call, the state update is done after making the transaction. this will lead to re-entrancy problem.
Vulnerability Details
function claim() external {
updateFor(msg.sender);
WETH.transfer(msg.sender, claimable[msg.sender]); --------->> transfer is done first.
claimable[msg.sender] = 0; --------------------------------->> state updated second
balance = WETH.balanceOf(address(this));
}
As shown in above code snip, claim call is updating the state update making the transaction.
Impact
Loss of funds.
Tools Used
Manual review.
Recommendations
function claim() external {
updateFor(msg.sender);
uint value = claimable[msg.sender] ;---------- +++
laimable[msg.sender] = 0;--------------------- +++
WETH.transfer(msg.sender, claimable[msg.sender]);
balance = WETH.balanceOf(address(this));
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.