Summary

In the constructor function, there are checks to ensure that the tokenContract, buyer, and seller addresses are not zero. But, there is no such check for the arbiter address.

Vulnerability Details

Add below code snippet in the constructor of Escrow.sol =>
if (arbiter == address(0)) revert Escrow__ArbiterZeroAddress();
Add below error in the IEscrow.sol =>
error Escrow__ArbiterZeroAddress();

Impact

If the arbiter is zero address, there will be a problem in the resolveDispute function where the arbiter is supposed to receive a fee.

Tools Used

Recommendations