Submission Details
Severity:
`newEscrow()` does not check reentry
Summary
Because the tokenContract parameter is from user.And it will call by tokenContract.safeTransferFrom(msg.sender, computedAddress, price);, this may have a risk of reentry. I suggest adding check to newEscrow()
https://github.com/Cyfrin/2023-07-escrow/blob/main/src/EscrowFactory.sol#L39
Recommendations
Add check reentry
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.