CodeHawks Escrow Contract - Competition Details

Summary

arbiterFee should have a cap.

Even if contract check the if (arbiterFee >= price) ,I think this is an exchange between the seller and the buyer. If the arbitration fee is too high, it will cause losses to both the seller and the buyer. On the other hand, when the arbitration fee is too high, it may be more attractive to the arbitrator to perform the arbitration, which may lead to some unnecessary arbitrations, resulting in some disputes and unfairness

Vulnerability Details

https://github.com/Cyfrin/2023-07-escrow/blob/main/src/Escrow.sol#L43

Impact

If the arbitration fee is too high, it will cause losses to both the seller and the buyer. On the other hand, when the arbitration fee is too high, it may be more attractive to the arbitrator to perform the arbitration, which may lead to some unnecessary arbitrations, resulting in some disputes and unfairness

Tools Used

manual

Recommendations

I think we can set a parameter such arbiterFee_MAX , and check it.