CodeHawks Escrow Contract - Competition Details

Summary

Solidity Order of Layout Style Guide not followed - Informational issue

Vulnerability Details

The Solidity Style Guide details how the Order of Layout of contracts should be:

Inside each contract, library or interface, use the following order:

1. Type declarations

2. State variables

3. Events

4. Errors

5. Modifiers

6. Functions

In the Escrow.sol contact, the constructor is above modifiers.
In the IEscrow.sol and IEscrowFactory.sol contracts, the errors are above events.

Impact

Solidity Style Guide not followed.

Tools Used

Manual review

Recommendations

Change the order of the layout to follow the Solidity Style Guide.