Submission Details
Severity:
Use totalFee to get contract balance
Summary
Querying the balance of the contract can be replaced by utilizing the 'totalFee' variable, which already holds the contract balance. By doing so, we can reduce the two 'balanceOf()' calls to just one, resulting in significant gas savings, averaging at 777 units.
https://github.com/Cyfrin/2023-07-escrow/blob/65a60eb0773803fa0be4ba72defaec7d8567bccc/src/Escrow.sol#L125
Gas Savings for Escrow.resolveDispute, obtained via protocol’s tests: Avg 777 gas
| | Med | Max | Avg | # calls |
|--------------------|----------|-----------|----------|----------|
| Before | 62460 | 62460 | 62460 | 1 |
| After | 61683 | 61683 | 61683 | 1 |
diff --git a/src/Escrow.sol b/src/Escrow.sol
index 5b5fd1f..4f9be56 100644
--- a/src/Escrow.sol
+++ b/src/Escrow.sol
contract Escrow is IEscrow, ReentrancyGuard {
if (i_arbiterFee > 0) {
i_tokenContract.safeTransfer(i_arbiter, i_arbiterFee);
}
- tokenBalance = i_tokenContract.balanceOf(address(this));
+ tokenBalance -= totalFee;
if (tokenBalance > 0) {
i_tokenContract.safeTransfer(i_seller, tokenBalance);
}
}
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.