40,000 USDC
View results
Submission Details
Severity: gas
Valid

Check for Arbiter Fee should not include price

Summary

Constructor does not allow arbiterFee to equal the price, which should be possible.

Vulnerability Details

In the escrows constructor there is a check if the arbiterFee >= price, otherwise it reverts. However there is no technical issue with the arbiterFee being equal to the price. Meaning, in case of a dispute the arbiter gets all the funds.

Impact

Cannot set arbiterFee to total price

Tools Used

  • neovim

  • manual code Review

Recommendations

Adjust the check, to only revert if arbiterFee > price

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.