Submission Details
Severity:
Low - Incorrect public visibilty of computeEscrowAddress
Summary
The visibility of computeEscrowAddress() should be changed to private.
Vulnerability Details
The function computeEscrowAddress() is only used in the EscrowFactory.sol and it is only called by the newEscrow() function, so there is no reason for the function to have public visibility.
Impact
Low
Tools Used
Manual review.
Recommend Mitigation
Rename the function to:
function computeEscrowAddress(
bytes memory byteCode,
address deployer,
uint256 salt,
uint256 price,
IERC20 tokenContract,
address buyer,
address seller,
address arbiter,
uint256 arbiterFee
) private pure returns (address) {}
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.