CodeHawks Escrow Contract - Competition Details

Summary

Good practice is to place the nonReentrant modifier first before other modifiers

Vulnerability Details

In Escrow.resolveDispute() the nonReentrant modifier is placed second after onlyArbiter(). In order for the nonReentrant modifier to check if the _status is not _ENTERED before any code is executed in the function , It should be placed first

Impact

None impact at all. Just following Solidity best practices

Tools Used

Manual Review

Recommendations

Rearrange the modifiers of Escrow.resolveDispute() and place the nonReentrant modifier first