Summary

The escrow contract does not support fee-on-transfer tokens. Popular token like USDT is actually a fee on transfer token with the fee currently set as 0.

Vulnerability Details

If a fee on transfer token is used, the Factory forwards price amount of tokens, and the escrow also expects the same price amount of tokens. This is an issue if any number of those tokens were deducted as transfer fees, and will revert the contract creation.

Impact

Contract creation reverts due to fees paid.

Tools Used

Manual review

Recommendations

Disallow usage of fee-on-transfer tokens