Submission Details
Severity:
G-02 By using assembly for the creat2 deployment in `newEscrow()` 548 gas can be saved
Summary
If assembly is used for the creat2 deployment, 548 gas can be saved each time a new escrow is created
Vulnerability Details
Impact
Tools Used
Recommendations
Replace the code in newEscrow() with the following:
function newEscrow(uint256 price, IERC20 tokenContract, address seller, address arbiter, uint256 arbiterFee, bytes32 salt ) external returns (IEscrow)
{
bytes memory bytecode = abi.encodePacked(type(Escrow).creationCode, abi.encode(price, tokenContract, msg.sender, seller, arbiter, arbiterFee));
address computedAddress = computeEscrowAddress(bytecode, address(this), uint256(salt));
tokenContract.safeTransferFrom(msg.sender, computedAddress, price);
address addr;
assembly{
addr := create2(0, add(bytecode, 0x20), mload(bytecode), salt)
}
if (addr != computedAddress) {
revert EscrowFactory__AddressesDiffer();
}
emit EscrowCreated(addr, msg.sender, seller, arbiter);
return IEscrow(addr);
}
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.