Submission Details
Severity:
The use of a logical AND in place of double if is slightly less gas efficient
Summary
The use of a logical AND in place of double if is slightly less gas efficient
Vulnerability Details
The use of a logical AND in place of double if is slightly less gas efficient in instances where there isn't a corresponding else statement for the given if statement
Using a double if statement instead of logical AND (&&) can provide similar short-circuiting behavior whereas double if is slightly more efficient.
File: /src/Escrow.sol
67: if (msg.sender != i_buyer && msg.sender != i_seller) {
revert Escrow__OnlyBuyerOrSeller();
Impact
Save gas
Tools Used
Manual
Recommendations
Use double If instead of "AND" operator
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215
USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.