Submission Details
Severity:
Long lines of code
Summary
Long lines of code
Vulnerability Details
Usually lines in source code are limited to 80 characters. Today's screens are much larger so it's reasonable to stretch this in some cases. The solidity style guide recommends a maximumum line length of 120 characters, so the lines below should be split when they reach that length.
File: /src/Escrow.sol
4: // Inspired by `BillOfSaleERC20` contract: https://github.com/open-esq/Digital-Organization-Designs/blob/master/Finance/BillofSaleERC20.sol
28: /// @dev Sets the Escrow transaction values for `price`, `tokenContract`, `buyer`, `seller`, `arbiter`, `arbiterFee`. All of
30: /// @dev Funds should be sent to this address prior to its deployment, via create2. The constructor checks that the tokens have
File: /src/IEscrowFactory.sol
12: /// @notice deploy a new escrow contract. The escrow will hold all the funds. The buyer is whoever calls this function.
Impact
Informational
Tools Used
Manual
Recommendations
limit the line number of chars to max 80 chars
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.