CodeHawks Escrow Contract - Competition Details
Cyfrin
Foundry
40,000 USDC
View results
Previous Next
Submission Details
Severity: gas
Valid

NatSpec `@param` is missing

oualidpro

Summary

NatSpec @param is missing

Vulnerability Details

File: /src/Escrow.sol
​
// @audit the @param price is missing
// @audit the @param tokenContract is missing
// @audit the @param buyer is missing
// @audit the @param seller is missing
// @audit the @param arbiter is missing
// @audit the @param arbiterFee is missing
​
@dev Sets the Escrow transaction values for `price`, `tokenContract`, `buyer`, `seller`, `arbiter`, `arbiterFee`. All of
these values are immutable: they can only be set once during construction and reflect essential deal terms.
@dev Funds should be sent to this address prior to its deployment, via create2. The constructor checks that the tokens have
been sent to this address.
32: constructor(
​

Link to code

File: /src/EscrowFactory.sol
​
// @audit the @param byteCode is missing
// @audit the @param deployer is missing
// @audit the @param salt is missing
// @audit the @param price is missing
// @audit the @param tokenContract is missing
// @audit the @param buyer is missing
// @audit the @param seller is missing
// @audit the @param arbiter is missing
// @audit the @param arbiterFee is missing
​
@dev See https://docs.soliditylang.org/en/latest/control-structures.html#salted-contract-creations-create2
56: function computeEscrowAddress(
​

Link to code

File: /src/IEscrow.sol
​
// @audit the @param buyerAward is missing
​
@notice Arbiter can resolve dispute and claim token reward by entering in split of `price` value,
minus `arbiterFee` set at construction.
43: function resolveDispute(uint256 buyerAward) external;
​

Link to code

Impact

Tools Used

Recommendations

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.