Submission Details
Severity:
State variables should include comments
Summary
State variables should include comments
Vulnerability Details
Consider adding some comments on critical state variables to explain what they are supposed to do: this will help for future code reviews.
File: /src/Escrow.sol
//@audit i_price need comments
17: uint256 private immutable i_price;
//@audit i_buyer need comments
21: address private immutable i_buyer;
//@audit i_seller need comments
22: address private immutable i_seller;
//@audit i_arbiter need comments
23: address private immutable i_arbiter;
//@audit i_arbiterFee need comments
24: uint256 private immutable i_arbiterFee;
//@audit s_state need comments
26: State private s_state;
Impact
Informational
Tools Used
Manual
Recommendations
add comments to critical state variables
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215
USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.