Submission Details
Severity:
nonReentrant modifier should be placed before all other modifiers.
Summary
The function Escrow.resolveDispute() uses the onlyArbiter and nonReentrant modifier, with this order.
Vulnerability Details
The nonReentrant modifier doesn't protect against reentrancy during the execution of the first modifier. Practically, there cannot be any reentrancy there when considering the current implementation of onlyArbiter, but it is still a best practice recommendation for safe programming.
File: 2023-07-escrow/src/Escrow.sol
109: function resolveDispute(uint256 buyerAward) external onlyArbiter nonReentrant inState(State.Disputed) {
Impact
Place modifiers in the right order as a best practice.
Tools Used
Manual code review.
Recommendations
Use the nonReentrant modifier before any other modifier.
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.