Summary

When a type is downcast to a smaller type, the higher order bits are truncated, effectively applying a modulo to the original value. Without any other checks, this wrapping will lead to unexpected behavior and bugs.

Vulnerability Details

There is 1 instance of this issue.

Impact

A hash collision would results in a incorrectly computed escrow address.

Tools Used

baudit: a custom static code analysis tool; manual review

Recommendations

Use OpenZeppelin's SafeCast so that transactions revert when such an operation overflows. Using this library instead of the unchecked operations eliminates an entire class of bugs, so it is recommended to always use it.