Submission Details
Severity:
Use leading underscore for `private` and `internal` function and variable names
Summary
According to the Solidity Style Guide, private and internal function and variable names should begin with an underscore.
Vulnerability Details
There are 7 instances of this issue.
View 7 Instances
File: src/Escrow.sol
17: uint256 private immutable i_price;
20: IERC20 private immutable i_tokenContract;
21: address private immutable i_buyer;
22: address private immutable i_seller;
23: address private immutable i_arbiter;
24: uint256 private immutable i_arbiterFee;
26: State private s_state;
| File Link | Instance Count | Instance Links |
|---|---|---|
| Escrow.sol | 7 | 17,20,21,22,23,24,26 |
Impact
Decreased readability/maintainability of project source code.
Tools Used
baudit: a custom static code analysis tool; manual review
Recommendations
Rename private and internal function and variable names to begin with an underscore.
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215
USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.