CodeHawks Escrow Contract - Competition Details

Summary

There is no description to the initiated dispute

Vulnerability Details

When a buyer or seller initiates a dispute there is no description or indication as to what the dispute is about, or ability to add in important notes and or category.

Impact

Informational: Allowing the dispute function to take a string description or some sort of code representative of offchain listed categories make for richer, more informative, better recording of disputes, data and information onchain and helps arbiters, developers and the buyer and seller understand why dispute was initiated. Not having this impacts the quality, usability and interpretability of the code.

Tools Used

Manual Analysis

Recommendations

function can be adjusted to take in string description. If strings are considered can be long, vague, ambigous then code related to its meaning offchain can be created e.g code 1 = time delay code 2 = incomplete job code 3 = quality etc
function initiateDispute(string _description) external onlyBuyerOrSeller inState(State.Created) {
if (i_arbiter == address(0)) revert Escrow__DisputeRequiresArbiter();
s_state = State.Disputed;
emit Disputed(msg.sender, _description);
}
The event can be adjusted in order to emit the string description or for the dispute