40,000 USDC
View results
Submission Details
Severity: gas

Events are missing sender information

Summary

Events are missing sender information

Vulnerability Details

When an action is triggered based on a user's action,
not being able to filter based on who triggered the
action makes event processing a lot more cumbersome.
Including the msg.sender the events of these types
of action will make events much more useful to end users,
especially when msg.sender is not tx.origin.

Instances (2):

File: src/Escrow.sol
96: emit Confirmed(i_seller);
121: emit Resolved(i_buyer, i_seller);

Link to code - https://github.com/Cyfrin/2023-07-escrow/tree/main/src/Escrow.sol

Tools Used

Custom analyzer tool

Recommendations

Add msg.sender to the events

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.