Summary

Add a check that buyer != seller != arbiter

Vulnerability Details

The contract can be currently initialized with values that are same for any combinations of buyer, seller and arbiter.

Impact

Such mistakes will cost gas to recover from, as the contract will require re-deployment with the proper values. This will lead to gas loss, time loss, and maybe the issue might not be realized until its too late.

Severity Justification

Marking this as medium as the following medium criteria satisfy:

• Disruption of protocol functionality or availability

Source: https://docs.codehawks.com/rewards-and-judging

Tools Used

Manual inspection

Recommendations

Add a check to ensure that buyer, seller and arbiter are always different in the constructor of the Escrow contract.