Submission Details
Severity:
The `nonReentrant` modifier should occur before all other modifiers
Summary
The nonReentrant modifier should occur before all other modifiers
Vulnerability Details
This is a best-practice to protect against reentrancy in other modifiers
109 function resolveDispute(uint256 buyerAward) external onlyArbiter nonReentrant inState(State.Disputed) {
https://github.com/Cyfrin/2023-07-escrow/blob/main/src/Escrow.sol#L109
Impact
Informational
Tools Used
Manual review
Recommendations
Use nonReentrant modifier before any other modifier
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215
USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.