40,000 USDC
View results
Submission Details
Severity: gas
Valid

The `nonReentrant` modifier should occur before all other modifiers

Summary

The nonReentrant modifier should occur before all other modifiers

Vulnerability Details

This is a best-practice to protect against reentrancy in other modifiers

109 function resolveDispute(uint256 buyerAward) external onlyArbiter nonReentrant inState(State.Disputed) {

https://github.com/Cyfrin/2023-07-escrow/blob/main/src/Escrow.sol#L109

Impact

Informational

Tools Used

Manual review

Recommendations

Use nonReentrant modifier before any other modifier

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.