In IEscrow.sol
, the Escrow__FeeExceedsPrice
error indicates that the Fee exceeds the price. Yet in Escrow.sol
, it checks if the fee exceeds or equals the price.
A user who sets the arbiter fee as equal to the price for whatever reason would not be able to.
Foundry
Replace the following line in Escrow.sol
:
with:
This will also save 25 gas during deployments.
If the check is intended as is, then this should be considered an INFO level finding, and the Escrow__FeeExceedsPrice
error should be renamed to Escrow__FeeExceedsOrIsEqualToPrice
.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.