CodeHawks Escrow Contract - Competition Details

Description

There are Incomplete, incorrect or ambiguous comments in the code.
Observation, the following instances were not mentioned in the bot analysis.

Recommend Mitigation

• in IEscrow::resolveDispute

  • change the natspec comment:

  Arbiter can resolve dispute and claim token reward by entering in split of price value minus arbiterFee set at construction.

  to a more understandable phrase, example: Arbiter can resolve a dispute and claim its token reward by providing the split value for buyer and seller, minus his arbiterFee which is set at construction.

  • add missing documentation on events and errors

• in IEscrowFactory

  • there is a typo; change ie to i.e.

  • add missing documentation on events and errors

• in EscrowFactory

  • the phrase ... to spend the price amount before ... is ambiguous; change it to ... to spend the token price amount before ...

• in Escrow

  • there is a missing an: add it before optional: and an optional arbiter

  • missing an and before the last element of the enumeration; add it: arbiter and arbiterFee.