Submission Details
Severity:
resolveDispute calls i_tokenContract.balanceOf twice
Summary
In Escrow.sol line 125 the amount sent to the seller is determined by calling i_tokenContract.balanceOf(address(this)) again. The data is already locally available in the function though and can be determined with tokenBalance - totalFee;
Recommendations
Just perform the subtraction rather than calling balanceOf a second time.
uint256 sellerAward = tokenBalance - totalFee;
if (sellerAward > 0) {
i_tokenContract.safeTransfer(i_seller, sellerAward);
}
Saves ~10000 gas on each of the resolve dispute tests.
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.