Submission Details
Severity:
getPrice() will return wrong value
Summary
getPrice() will return the wrong value as i_price
Vulnerability Details
function getPrice() external view returns (uint256) {
return i_price;
}
getPrice() returns i_price and i_price can be set at the deployment of the contract. initially i_price will be a token balance deposited to the contract. But if the Buyer transfers tokens directly to the contract, it will not update the i_price, and getPrice() will return the wrong old value.
Impact
getPrice() will return the wrong value, which can affect displaying the wrong value and affect user experience.
Tools Used
Manual Review
Recommendations
return the contract token balance
function getPrice() external view returns (uint256) {
return i_tokenContract.balanceOf(address(this));;
}
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.