Submission Details
Severity:
nonReentrant modifier can be replaced by CEI pattern
Description
In resolveDispute the state can be changed to Resolved before doing any other thing. This allows for the nonReentrant modifier to be removed as no function can be reentered when the state is set to Resolved. Given that the likelihood of resolveDispute to revert on call multiple times is low, this change also makes sense at a gas level, given that it removes the nonReentrant modifier cost (small as it is).
function resolveDispute(uint256 buyerAward) external onlyArbiter inState(State.Disputed) {
++ s_state = State.Resolved;
uint256 tokenBalance = i_tokenContract.balanceOf(address(this));
uint256 totalFee = buyerAward + i_arbiterFee; // Reverts on overflow
if (totalFee > tokenBalance) {
revert Escrow__TotalFeeExceedsBalance(tokenBalance, totalFee);
}
-- s_state = State.Resolved;
emit Resolved(i_buyer, i_seller);
// ...rest of the code
}
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.