Token address(0) check misplaced/not required
Summary
The address(0) check for tokenContract is intended to prevent client-side errors when a zero token address is used to deploy an Escrow. In the existing code base, this check takes place in the Escrow constructor, after the token amount has been transferred; this makes little sense as by that time the transfer would already have failed.
Vulnerability Details
Not a vulnerability. See Summary.
Impact
Tools Used
Recommendations
Neither approval nor transfer of an address(0) token is possible, and thus the check in Escrow is misplaced. Suggest either moving it to newEscrow or removing altogether to conserve nSLOC and deployment gas.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.