Submission Details
Severity:
Unnecessary call to .balanceOf
Summary
i_tokenContract.balanceOf(address(this)) called twice in the scope of resolveDispute`. This can be avoided by calculating the remainder of the token balance in-function.
Vulnerability Details
Before the update:
Deployment Cost | Deployment Size
Function Name | min | avg | median | max | # calls |
resolveDispute | 383 | 27017 | 22342 | 62460 | 8
After the update:
Deployment Cost | Deployment Size
Function Name | min | avg | median | max | # calls |
resolveDispute | 377 | 26622 | 21946 | 61683 | 8 |
Impact
Tools Used
forge t --gas-report
Recommendations
Change L125 from
tokenBalance = i_tokenContract.balanceOf(address(this));
to
tokenBalance -= totalFee;
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215 USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.