40,000 USDC
View results
Submission Details
Severity: low
Valid

Lack of proper event emission at resolveDispute function.

Summary

The resolveDispute function in the contract does not include all of the relevant information in the Resolved event.

Vulnerability Details

The resolveDispute function does not include all of the relevant information in the Resolved event. The event emits the buyer and seller addresses. However, it does not include any other information, such as the buyer award, the arbiter fee, or the amount paid to the buyer.

Impact

The lack of emission of critical parameters in the event could affect users with the front-end, as not all data will be shown there. Additionally, external observers or off-chain systems may not have access to critical information about the resolution of the dispute.

Tools Used

Manual Analysis

Recommendations

Consider adding the following information in the event emitted.

event Resolved(
address indexed buyer,
address indexed seller,
uint256 buyerAward,
uint256 arbiterFee,
uint256 amountPaidToBuyer
);

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.