Submission Details
Severity:
`Escrow` redundantly checks for tokenBalance
Summary
Escrow unnecessarily checks if the contract has enough token balance. This is already guaranteed in EscrowFactory::newEscrow.
Vulnerability Details
Assuming Escrow only deploys through EscrowFactory, there is no need to check if the new Escrow has enough balance. EscrowFactory transfers tokens before deployment.
Impact
Deploying a new Escrow takes more gas than necessary. On average this consumes 1229 more gas.
Tools Used
Manual Review
Recommendations
Remove the check in Escrow::constructor.
Prize pool breakdown
Total prize
40,000 USDC
nSLOC
186215
USDC / LOC
37,000 USDC
3,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.