CodeHawks Escrow Contract - Competition Details

Summary

Comments should be clear and the functionality of the function and it's parameter should be clearly mentioned.

Vulnerability Details

In the IEscrow.sol contract, the code comment of resolveDispute function is rather ambiguous and the function parameter and it's functionality is not documented properly.

Impact

It creates ambiguity and misinterpretation for the function and it's functionality.

Tools Used

Manual Analysis

Recommendations

Add a clear NatSpec comment for the function and it's parameters which clearly explains the functionality of the function.