CodeHawks Escrow Contract - Competition Details

Summary

More parameters should be emitted from events.

Vulnerability Details

Event logs are crucial for off-chain services as they notify external users, such as a listening frontend website or client application, that something has happened on the blockchain. In the Escrow contract and EscrowFactory contract, some parameters like i_arbiterFee, i_price, buyerAward are never emitted hindering the task of off-chain services.

Impact

Certain values which are updated in user interface are done with the help of parameters from event logs can't be updated as there are no events parameters to notify these values. Hence, Front-end won't be much transparent and external users are not notified about important changes.

Tools Used

Manual Analysis

Recommendations

Add more events parameters i_arbiterFee, i_price, buyerAward, etc which might be required for off-chain services like front-ends and user interfaces to be more transparent.